Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] .github/workflows: add trigger phrase to conformance ingress workflow name #28087

Merged
merged 2 commits into from Sep 14, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Sep 12, 2023

Backport:

Once this PR is merged, you can update the PR labels via:

for pr in 27304 27822; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=27304,27822

@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Sep 12, 2023
@tklauser tklauser requested review from a team as code owners September 12, 2023 07:57
@tklauser
Copy link
Member Author

/test-backport-1.13

Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I don't see ci-ingress as manual trigger in the config for v1.13: https://github.com/cilium/cilium/blob/v1.13/.github/ariane-config.yaml

Did we miss backporting the commit that added to the config on main?

sayboras and others added 2 commits September 13, 2023 10:54
[ upstream commit 77184ed ]

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
… name

[ upstream commit d91c819 ]

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from a team as a code owner September 13, 2023 08:54
@tklauser
Copy link
Member Author

Wait, I don't see ci-ingress as manual trigger in the config for v1.13: https://github.com/cilium/cilium/blob/v1.13/.github/ariane-config.yaml

Did we miss backporting the commit that added to the config on main?

Pulled in backport of commit 77184ed from #27304 (only first commit) which adds the respective ariane config.

@tklauser
Copy link
Member Author

/test-backport-1.13

Comment on lines +35 to +37
/ci-gateway-api:
workflows:
- conformance-gateway-api.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so now we have to add ci-gateway-api to the name in .github/workflows/conformance-gateway-api.yaml xD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah but it's missing on main: https://github.com/cilium/cilium/blob/main/.github/workflows/conformance-gateway-api.yaml

So disregard I guess? Fix on main and backport?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say disregard for now and fix/backport later as it will again need manual adjustment of required checks on all affected branches 😞

@julianwiedmann julianwiedmann merged commit fc3d00b into v1.13 Sep 14, 2023
117 checks passed
@julianwiedmann julianwiedmann deleted the pr/v1.13-backport-2023-09-12 branch September 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants