New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.13] .github/workflows: add trigger phrase to conformance ingress workflow name #28087
Conversation
/test-backport-1.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I don't see ci-ingress
as manual trigger in the config for v1.13: https://github.com/cilium/cilium/blob/v1.13/.github/ariane-config.yaml
Did we miss backporting the commit that added to the config on main?
df17095
to
48a5a85
Compare
Pulled in backport of commit 77184ed from #27304 (only first commit) which adds the respective ariane config. |
/test-backport-1.13 |
/ci-gateway-api: | ||
workflows: | ||
- conformance-gateway-api.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so now we have to add ci-gateway-api
to the name in .github/workflows/conformance-gateway-api.yaml
xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaah but it's missing on main
: https://github.com/cilium/cilium/blob/main/.github/workflows/conformance-gateway-api.yaml
So disregard I guess? Fix on main and backport?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say disregard for now and fix/backport later as it will again need manual adjustment of required checks on all affected branches 😞
Backport:
v1.13
branch.Once this PR is merged, you can update the PR labels via:
or with