Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v1.14: CI: Add IPsec key rotation test #28105

Merged
merged 3 commits into from Sep 13, 2023

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Sep 12, 2023

Manual backport of

for pr in 26730 27203 27883; do contrib/backporting/set-labels.py $pr done 1.14; done

Signed-off-by: Zhichuan Liang gray.liang@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Sep 12, 2023
[ upstream commit 4c85662 ]

[ backporter's note: .github/workflows/conformance-ipsec-e2e.yaml was
accidentally backported by 2aab44b, so
we only handle the remaining parts. ]

IPsec cases are moved from conformance-e2e.yaml to
conformance-ipsec-e2e.yaml, we can trigger the latter one using
/ci-ipsec-e2e.

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@jschwinger233
Copy link
Member Author

/ci-ipsec-e2e

jschwinger233 and others added 2 commits September 12, 2023 21:17
[ upstream commit a4d543d ]

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
[ upstream commit 751c17c ]

Now that we cover the key rotations in the IPsec e2e tests, we are
running the connectivity test suite twice. That means we can run in the
usual bug where an existing CT entry is reused and leads to us sending
traffic to the proxy when we shouldn't.

Thus, we need to flush the CT entries at the end of the first test run,
with --flush-ct.

Fixes: de192de ("ci-ipsec-e2e: Add IPsec key rotation test")
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@jschwinger233
Copy link
Member Author

/ci-ipsec-e2e

@jschwinger233
Copy link
Member Author

/ci-ipsec-upgrade

@jschwinger233
Copy link
Member Author

/test-backport-1.14

@jschwinger233 jschwinger233 marked this pull request as ready for review September 13, 2023 07:08
@jschwinger233 jschwinger233 requested review from a team as code owners September 13, 2023 07:08
@jschwinger233
Copy link
Member Author

I suppose it's ready to merge? Let me know if anything requires change.

@jschwinger233 jschwinger233 added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 13, 2023
@brb
Copy link
Member

brb commented Sep 13, 2023

I suppose it's ready to merge? Let me know if anything requires change.

Yep!

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 13, 2023
@julianwiedmann julianwiedmann merged commit 234b873 into v1.14 Sep 13, 2023
200 checks passed
@julianwiedmann julianwiedmann deleted the pr/gray/v1.14-ipsec-e2e branch September 13, 2023 13:29
@maintainer-s-little-helper maintainer-s-little-helper bot removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.14 This PR represents a backport for Cilium 1.14.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants