Refactor CiliumExecContext() Retry Logic #28131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
christarazi
approved these changes
Sep 12, 2023
christarazi
added
kind/bug/CI
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
tklauser
reviewed
Sep 13, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
carnerito
force-pushed
the
tests-cilium-exec-fix
branch
from
7056c6a
to
180ae99
Compare
Previously, the CiliumExecContext() function would retry the cilium command up to 5 times (limitTimes) without verifying the success of previous executions. This pull request introduces a logic enhancement that validates the return code of each executed command and exits upon success. Additionally, this change optimizes test execution time by reducing unnecessary retries. With a 200ms delay between retries, the overall test execution time is expected to improve by at least 200ms multiplied by the number of cilium commands and the number of cilium pods involved. Local Ginkgo tests, specifically those focused on 'K8sDatapathBGPTests' 'K8sDatapathCustomCalls' and 'K8sDatapathLRPTests' have shown significant improvements: Before: `Ran 2 of 106 Specs in 233.348 seconds` After: `Ran 2 of 106 Specs in 168.563 seconds` Signed-off-by: Boris Petrovic <carnerito.b@gmail.com>
carnerito
force-pushed
the
tests-cilium-exec-fix
branch
from
180ae99
to
4a5366d
Compare
|
@christarazi I have fixed |
tklauser
removed
the
ready-to-merge
|
/test |
tklauser
added
affects/v1.11
maintainer-s-little-helper
bot
added
the
ready-to-merge
doniacld
added
backport-pending/1.13
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the CiliumExecContext() function would retry the cilium command up to 5 times (limitTimes) without verifying the success of previous executions. This pull request introduces a logic enhancement that validates the return code of each executed command and exits upon success.
Additionally, this change optimizes test execution time by reducing unnecessary retries. With a 200ms delay between retries, the overall test execution time is expected to improve by at least 200ms multiplied by the number of cilium commands and the number of cilium pods involved.
Local Ginkgo tests, specifically those focused on 'K8sDatapathBGPTests' 'K8sDatapathCustomCalls' and 'K8sDatapathLRPTests' have shown significant improvements:
Before:
Ran 2 of 106 Specs in 233.348 secondsAfter:
Ran 2 of 106 Specs in 168.563 secondsSigned-off-by: Boris Petrovic carnerito.b@gmail.com