Commits on Sep 13, 2023

1. Refactor CiliumExecContext() Retry Logic …

   Previously, the CiliumExecContext() function would retry the cilium command up to 5 times (limitTimes) without verifying the success of previous executions. This pull request introduces a logic enhancement that validates the return code of each executed command and exits upon success.
   
   Additionally, this change optimizes test execution time by reducing unnecessary retries. With a 200ms delay between retries, the overall test execution time is expected to improve by at least 200ms multiplied by the number of cilium commands and the number of cilium pods involved.
   
   Local Ginkgo tests, specifically those focused on 'K8sDatapathBGPTests' 'K8sDatapathCustomCalls' and 'K8sDatapathLRPTests' have shown significant improvements:
   
   Before:
   `Ran 2 of 106 Specs in 233.348 seconds`
   
   After:
   `Ran 2 of 106 Specs in 168.563 seconds`
   
   Signed-off-by: Boris Petrovic <carnerito.b@gmail.com>

   

   carnerito committed Sep 13, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 4a5366d
   • Browse repository at this point

   Copy the full SHA

   4a5366d View commit details

   Browse the repository at this point in the history