Makefile: fix 'fast' make targets #28380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
These targets failed to select the nodes of a kind cluster. This change selects the right variables that are used to check for the cluster nodes. Fixes: 5f88bbf ("docs: Add Makefile and documentation for "fast" development targets") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
needs-backport/1.14
|
/test |
The kind-install-cilium-fast should install Cilium on all available kind clusters. Fixes: 5f88bbf ("docs: Add Makefile and documentation for "fast" development targets") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-makefile-targets
branch
from
c37bf45
to
e9c10b8
Compare
|
/test |
jibi
approved these changes
Oct 5, 2023
sayboras
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
jrajahalme
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These targets failed to select the nodes of a kind cluster. This change selects the right variables that are used to check for the cluster nodes.
Fixes 5f88bbf ("docs: Add Makefile and documentation for "fast" development targets")