Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goleak: Errors on successful test run: found unexpected goroutines: k8s.io/client-go/util/workqueue.(*delayingType).waitingLoop #28477

Closed
giorio94 opened this issue Oct 10, 2023 · 3 comments · Fixed by #28557
Assignees
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.

Comments

@giorio94
Copy link
Member

CI failure

Hit on unrelated PR: #27232

2023-10-09T09:10:17.2939044Z FAIL	github.com/cilium/cilium/operator/pkg/lbipam	4.408s

2023-10-09T09:10:17.2929437Z goleak: Errors on successful test run: found unexpected goroutines:
2023-10-09T09:10:17.2931023Z [Goroutine 87 in state select, with k8s.io/client-go/util/workqueue.(*delayingType).waitingLoop on top of the stack:
2023-10-09T09:10:17.2932040Z goroutine 87 [select]:
2023-10-09T09:10:17.2933690Z k8s.io/client-go/util/workqueue.(*delayingType).waitingLoop(0xc000869320)
2023-10-09T09:10:17.2935011Z 	/host/vendor/k8s.io/client-go/util/workqueue/delaying_queue.go:276 +0x305
2023-10-09T09:10:17.2937442Z created by k8s.io/client-go/util/workqueue.newDelayingQueue in goroutine 74
2023-10-09T09:10:17.2938366Z 	/host/vendor/k8s.io/client-go/util/workqueue/delaying_queue.go:113 +0x21f
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Oct 10, 2023
@joestringer joestringer changed the title CI: integration tests - pkg/lbipam: found unexpected goroutines goleak: Errors on successful test run: found unexpected goroutines: k8s.io/client-go/util/workqueue.(*delayingType).waitingLoop Oct 11, 2023
@joestringer joestringer added the sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. label Oct 11, 2023
@joestringer
Copy link
Member

I'm not entirely sure whether area/ci + ci/flake are the right labels. This looks more like a code correctness issue identified by CI.

@thorn3r
Copy link
Contributor

thorn3r commented Oct 11, 2023

hit here as well: https://github.com/cilium/cilium/actions/runs/6483079306/attempts/1. I see at least 1 other similar, recent failure in the job history as well https://github.com/cilium/cilium/actions/runs/6483875611

@joestringer
Copy link
Member

I know Dylan was looking into this so I'll assign him for now. It looks like it may have been introduced by #27340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants