test: Ignore waitqueue.waitingLoop goroutine leak #28557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use goleak in certain tests to ensure we do not leak goroutines which might cause unexpected behavior during tests or shutdown in production. Normally we expect our own goroutines to leak, but since we started using the delayed workqueue, we also leak the waitqueue.waitingLoop. This goroutine does get a shutdown signal when hive stops, but it isn't guaranteed to have exited before hive does so it sometimes triggers in CI. This commit adds and exception to all goleak invocation that use resource.Resource[T] to ignore the waitqueue.waitingLoop goroutine. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
added
area/CI
|
/test |
squeed
approved these changes
Oct 12, 2023
thorn3r
approved these changes
Oct 16, 2023
aditighag
approved these changes
Oct 16, 2023
|
@dylandreimerink looks like v1.14 is also seeing hitting this (https://github.com/cilium/cilium/actions/runs/6850169361/job/18623961162). Any concern about backporting - and if so, how far? |
|
Had not considered this might impact older releases, but backporting this should be easy, adding the label now |
dylandreimerink
added
the
needs-backport/1.14
gandro
added
backport-pending/1.14
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use goleak in certain tests to ensure we do not leak goroutines which might cause unexpected behavior during tests or shutdown in production.
Normally we expect our own goroutines to leak, but since we started using the delayed workqueue, we also leak the waitqueue.waitingLoop. This goroutine does get a shutdown signal when hive stops, but it isn't guaranteed to have exited before hive does so it sometimes triggers in CI.
This PR adds and exception to all goleak invocation that use resource.Resource[T] to ignore the waitqueue.waitingLoop goroutine.
Fixes: #28477