Fix IPv6 cilium_host address assignment #28633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
This time against main and with better description I hope. I need somebody who uses tunelling to test this thoguh, we use eBGP with /120 per node and pod subnet being within the same /64. |
CallMeFoxie
force-pushed
the
ar/fixipv6-main
branch
from
d405c9e
to
1207b4f
Compare
|
Nit: Could you change the commit message to something like: That way we reference my commit that introduced the bug and explain that this happened when moving away from |
rgo3
added
the
needs-backport/1.14
CallMeFoxie
force-pushed
the
ar/fixipv6-main
branch
from
1207b4f
to
ee79717
Compare
|
Is it not auto-linking the bug commit because of the # in front of the SHA? I guess you only need that for issues 🤦 Sorry for being so nit picky here, but the whole idea of the proposed commit message was to be able to click through to the bad commit. |
rgo3
changed the title
Fixes cilium#28327 This patch fixes the subnet assigned to the cilium_host device from /64 back to /128, a bug introduced in ecd4fc0 when converting the init.sh script to Go code. The conversion never meant to change the behavior in init.sh and the bug caused connectivity issues in certain cilium configurations. Signed-off-by: Ashley Reese <ashley@victorianfox.com>
CallMeFoxie
force-pushed
the
ar/fixipv6-main
branch
from
ee79717
to
12e83d0
Compare
|
better :) |
|
Thank you! 🙏 |
|
/test |
ti-mo
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
rgo3
approved these changes
Oct 17, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.14
tklauser
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28327
This patch stops adding /64 route to the cilium_net iface, which brought all the traffic to local node. When using something like /128 per node and having pods within the same /64 as the node meant that no cross-node traffic from pods worked.