Correctly use cli installer action in ipv4/6 smoke #28661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
joestringer
requested changes
Oct 17, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
bleggett
changed the title
joestringer
reviewed
Oct 17, 2023
|
^ Context, we try to keep Cilium git log linear for easier bisectability, and keep the commit messages simple and well-written so that future contributors can read back into the history and understand the context of the changes. The original commit message is good from that perspective, but the second one lacks context. Perhaps squash them all together during the rebase and just reword the commit to drop the IPv6 part? |
bleggett
force-pushed
the
bleggett/use-action-ipv6-smoke
branch
from
0c63f02
to
f702f99
Compare
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/use-action-ipv6-smoke
branch
from
f702f99
to
987fc87
Compare
nbusseneau
approved these changes
Oct 18, 2023
|
Both affected workflows passed, no need to run the rest of the CI on this one, marking ready to merge. |
nbusseneau
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for regression in smoke test script introduced by #25493
See https://github.com/cilium/cilium/pull/25493/files#r1362783422