Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add CiliumPodIPPool option in BGP Adv. Path Attributes docs #29177

Merged
merged 1 commit into from Nov 29, 2023
Merged

docs: Add CiliumPodIPPool option in BGP Adv. Path Attributes docs #29177

merged 1 commit into from Nov 29, 2023

Conversation

rastislavs
Copy link
Contributor

Updates BGP Advertised Path Attributes documentation with the new SelectorType option: CiliumPodIPPool added by #28310

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2023
@rastislavs rastislavs added the release-note/misc This PR makes changes that have no direct user impact. label Nov 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2023
@rastislavs rastislavs added area/bgp area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/cleanup This includes no functional changes. labels Nov 15, 2023
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs marked this pull request as ready for review November 15, 2023 09:32
@rastislavs rastislavs requested review from a team as code owners November 15, 2023 09:32
@rastislavs
Copy link
Contributor Author

@danehans could you please take a look?

@rastislavs
docs: Add CiliumPodIPPool option in BGP Adv. Path Attributes docs
a3a3840 
Updates BGP Advertised Path Attributes documentation with the new
`SelectorType` option: `CiliumPodIPPool`.

Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
@rastislavs
Copy link
Contributor Author

/test

@rastislavs rastislavs added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 28, 2023
@tklauser tklauser added this pull request to the merge queue Nov 29, 2023
Merged via the queue into cilium:main with commit ddfbf38 Nov 29, 2023
59 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

@lambdanis lambdanis lambdanis approved these changes

@ldelossa ldelossa ldelossa approved these changes

@harsimran-pabla harsimran-pabla harsimran-pabla approved these changes

@danehans danehans Awaiting requested review from danehans

Assignees
No one assigned
Labels
area/bgp area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rastislavs @nickolaev @lambdanis @ldelossa @harsimran-pabla @tklauser