Network performance #30247
Merged
Network performance #30247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
marseel
force-pushed
the
add_net_perf_ci
branch
9 times, most recently
from
6932a2b
to
0829f45
Compare
|
Commit 0829f45 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
marseel
force-pushed
the
add_net_perf_ci
branch
from
0829f45
to
399e55e
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
marseel
force-pushed
the
add_net_perf_ci
branch
5 times, most recently
from
68731c2
to
9cf04c5
Compare
marseel
force-pushed
the
add_net_perf_ci
branch
4 times, most recently
from
87f4051
to
a198d82
Compare
marseel
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
marseel
force-pushed
the
add_net_perf_ci
branch
from
a198d82
to
997ee67
Compare
aanm
added
backport-done/1.15
github-actions
bot
added
backport-done/1.14
nbusseneau
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.12
github-actions
bot
added
backport-done/1.13
This was referenced Feb 13, 2024
marseel
added a commit
that referenced
this pull request
Feb 14, 2024
While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Feb 20, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
that referenced
this pull request
Feb 20, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
that referenced
this pull request
Feb 20, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
that referenced
this pull request
Feb 20, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
that referenced
this pull request
Feb 21, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
pushed a commit
that referenced
this pull request
Feb 21, 2024
[ upstream commit dc6cf34 ] While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
| run: | | ||
| cilium status --wait --wait-duration=10m | ||
| kubectl get pods -n kube-system | ||
| kubectl -n kube-system exec daemonset/cilium -- cilium-dbg status |
There was a problem hiding this comment.
@marseel Drive-by - is this workflow actually working on v1.13 and v1.14 ? We backported the cilium-dbg part as-is, but back then the name was different.
There was a problem hiding this comment.
Looks like it has only been running on main: https://github.com/cilium/cilium/actions/workflows/net-perf-gke.yaml?query=
There was a problem hiding this comment.
Scheduled workflows are run only from the default branch.
The scheduled runs for the other Ariane-triggered workflows are run through https://github.com/cilium/cilium/blob/main/.github/workflows/ariane-scheduled.yaml, but we would need to extend that to also cover this workflow (if that's the goal, which I guess it is).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce network performance testing in CI.
Commit messages copied for convenience:
Example run: https://github.com/cilium/cilium/actions/runs/7612606888