Fix datapath mode in Network Performance CI test #30756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode. Unfortunately, setting `native` makes it actually use `tunneling` mode. Switching to `gke` mode resolves this issue. Fixes #30247 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
fix_net_perf_native_case
branch
from
64569d2
to
86ddfa8
Compare
marseel
changed the title
|
/test |
thorn3r
approved these changes
Feb 14, 2024
viktor-kurchenko
approved these changes
Feb 14, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
julianwiedmann
added
needs-backport/1.13
tklauser
added
backport-pending/1.15
tklauser
added
the
backport-pending/1.14
tklauser
removed
the
needs-backport/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.7
tklauser
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.13
github-actions
bot
added
backport-done/1.15
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing one of the review comments in PR that introduced this test, I changed datapath mode to be explicitly set from matrix.mode:
--datapath-mode=${{ matrix.mode }}Unfortunately, setting
nativemakes it actually usetunneling😮💨Fixes #30247
Run https://github.com/cilium/cilium/actions/runs/7899510472
I've verified that now the results look as they should.