CFP: Local internalTrafficPolicy support for ClusterIP advertisements with BGP Control Plane #31389
Assignees
Labels
area/bgp
help-wanted
Please volunteer for this by adding yourself as an assignee!
kind/feature
This introduces new functionality.
sig/agent
Cilium agent related.
Comments
rastislavs
added
help-wanted
|
@rastislavs OK Please assign to me. |
chaunceyjiang
added a commit
to chaunceyjiang/cilium
that referenced
this issue
Mar 22, 2024
Fixes: cilium#31389 As the ClusterIP services can have .spec.internalTrafficPolicy set to Local, advertising a ClusterIP from a node which has no local endpoints may cause unreachability of the advertised service if the traffic is routed to that node. So if .spec.internalTrafficPolicy of a service is set to Local, advertise its ClusterIP over BGP only if it has non-zero local endpoints. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 25, 2024
Fixes: #31389 As the ClusterIP services can have .spec.internalTrafficPolicy set to Local, advertising a ClusterIP from a node which has no local endpoints may cause unreachability of the advertised service if the traffic is routed to that node. So if .spec.internalTrafficPolicy of a service is set to Local, advertise its ClusterIP over BGP only if it has non-zero local endpoints. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
rzdebskiy
pushed a commit
to rzdebskiy/cilium
that referenced
this issue
Apr 3, 2024
Fixes: cilium#31389 As the ClusterIP services can have .spec.internalTrafficPolicy set to Local, advertising a ClusterIP from a node which has no local endpoints may cause unreachability of the advertised service if the traffic is routed to that node. So if .spec.internalTrafficPolicy of a service is set to Local, advertise its ClusterIP over BGP only if it has non-zero local endpoints. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cilium Feature Proposal
Add support for
.spec.internalTrafficPolicy: LocalinClusterIPservice advertisements with BGP Control Plane.Is your proposed feature related to a problem?
In PR #30963 (issue #30875) we added support for
ClusterIPservice advertisements with BGP Control Plane.At the moment, the ClusterIP service prefixes are advertised from each BGP-enabled cilium node.
As the
ClusterIPservices can have.spec.internalTrafficPolicyset toLocal, advertising a ClusterIP from a node which has no local endpoints may cause unreachability of the advertised service if the traffic is routed to that node:(source)
Describe the feature you'd like
If
.spec.internalTrafficPolicyof a service is set toLocal, advertise itsClusterIPover BGP only if it has non-zero local endpoints.(Optional) Describe your proposed solution
BGP control plane already supports similar handling of
spec.externalTrafficPolicy: LocalforLoadBalancerservices, so ideally the existing logic needs to be just extended to handle.spec.internalTrafficPolicy: Localas well on few places in the service reconciler (e.g. in svcDesiredRoutes handling).The text was updated successfully, but these errors were encountered: