Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Make CI tests fail after completion if a NACK is received from Envoy. #4003

Closed
jrajahalme opened this issue May 4, 2018 · 0 comments
Closed

CI: Make CI tests fail after completion if a NACK is received from Envoy. #4003

jrajahalme opened this issue May 4, 2018 · 0 comments
Assignees
@eloycoto
Labels
area/CI Continuous Integration testing issue or flake kind/enhancement This would improve or streamline existing functionality. priority/medium This is considered important, but not urgent.

Comments

@jrajahalme
Copy link
Member

A negative acknowledgement from Envoy signals a bug in cilium-envoy control messaging. As such, we should fail a test if it happens, even if the test otherwise would succeed.
The string to look for in cilium logs is: NACK received for version

Example log with a NACK:

2018-05-02T18:12:11.553169579Z level=warning msg="NACK received for version 1; waiting for a version update before sending again" xdsClientNode="id:\"host~127.0.0.1~no-id~localdomain\" cluster:\"cluster1\" build_version:\"73a30b301854eafb7954263e8792ed2fcca51da6/1.7.0-dev/Distribution/RELEASE\" " xdsNonce=1 xdsStreamID=1 xdsTypeURL=type.googleapis.com/envoy.api.v2.Listener xdsVersionInfo=
@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. priority/medium This is considered important, but not urgent. area/CI Continuous Integration testing issue or flake labels May 4, 2018
@jrajahalme jrajahalme mentioned this issue May 4, 2018
Closed
@eloycoto eloycoto mentioned this issue May 4, 2018
Merged
eloycoto added a commit to eloycoto/cilium that referenced this issue May 4, 2018
@eloycoto
Test: Add NACK message in log checks.
2398bbb 
Refactored the log messages checker and added NACK message

Fix cilium#4003

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
ianvernon pushed a commit that referenced this issue May 4, 2018
@eloycoto @ianvernon
Test: Add NACK message in log checks.
e8a3aeb 
Refactored the log messages checker and added NACK message

Fix #4003

Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eloycoto eloycoto

Labels
area/CI Continuous Integration testing issue or flake kind/enhancement This would improve or streamline existing functionality. priority/medium This is considered important, but not urgent.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eloycoto @jrajahalme