Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: remove Map.DeleteWithErrno() #10058

Merged
merged 1 commit into from Feb 18, 2020
Merged

bpf: remove Map.DeleteWithErrno() #10058

merged 1 commit into from Feb 18, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Feb 5, 2020 •
edited by tgraf

Map.Delete() now wraps the underlying errno when returning an error.

Therefore, Map.DeleteWithErrno() is rendered obsolete as checking for an error of type syscall.Errno can now be done using errors.Is() or errors.As() with the error returned by Map.Delete().

Fixes #8324

This change is Reviewable

@rolinh rolinh added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Feb 5, 2020
@rolinh rolinh requested a review from a team February 5, 2020 12:24
@rolinh rolinh requested a review from a team as a code owner February 5, 2020 12:24
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 5, 2020
@rolinh
Copy link
Member Author

rolinh commented Feb 5, 2020

test-me-please

@coveralls
Copy link

coveralls commented Feb 5, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 44.563% when pulling 0d0eb3f on pr/rolinh/remove-map-delete-with-errno into da2e652 on master.

@rolinh
Copy link
Member Author

rolinh commented Feb 5, 2020

test-me-please

@aanm aanm added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 7, 2020
@rolinh rolinh force-pushed the pr/rolinh/remove-map-delete-with-errno branch from 20e69bd to 67477e1 Compare February 8, 2020 20:45
@rolinh rolinh requested a review from a team as a code owner February 8, 2020 20:45
@rolinh
Copy link
Member Author

rolinh commented Feb 8, 2020

test-me-please

@rolinh
Copy link
Member Author

rolinh commented Feb 8, 2020

@joestringer PTAL, there was an issue with Delete() re-definition for the ipcache map and I had to rename it.

@rolinh rolinh mentioned this pull request Feb 10, 2020
Merged
@rolinh rolinh force-pushed the pr/rolinh/remove-map-delete-with-errno branch from 67477e1 to f5b42b9 Compare February 11, 2020 08:59
@rolinh
Copy link
Member Author

rolinh commented Feb 11, 2020

test-me-please

@rolinh rolinh mentioned this pull request Feb 12, 2020
Closed
@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

vm provisioning fail, will trigger the tests again

@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

test-me-please

@rolinh rolinh force-pushed the pr/rolinh/remove-map-delete-with-errno branch from f5b42b9 to 7835747 Compare February 12, 2020 08:38
@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

Rebased against master as there are new timeouts for Gingko test to resolve VM provisioning failures (adfa9e7).

@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

test-me-please

@rolinh
bpf: remove Map.DeleteWithErrno()
0d0eb3f 
`Map.Delete()` now wraps the underlying errno when returning an error.

Therefore, `Map.DeleteWithErrno()` is rendered obsolete as checking for
an error of type `syscall.Errno` can now be done using `errors.Is()` or
`errors.As()` with the error returned by `Map.Delete()`.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh force-pushed the pr/rolinh/remove-map-delete-with-errno branch from 7835747 to 0d0eb3f Compare February 12, 2020 13:50
@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

vm provisioning failed again :(
@nebril is looking into this

@rolinh
Copy link
Member Author

rolinh commented Feb 12, 2020

test-me-please

@Ropes Ropes mentioned this pull request Feb 16, 2020
Merged
@aanm aanm added this to the 1.8 milestone Feb 18, 2020
@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 18, 2020
@aanm aanm merged commit cfb7333 into master Feb 18, 2020
1.8.0 automation moved this from In progress to Merged Feb 18, 2020
@aanm aanm deleted the pr/rolinh/remove-map-delete-with-errno branch February 18, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Remove Map.DeleteWithErrno()
4 participants
@rolinh @coveralls @joestringer @aanm