Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Add test for __ct_lookup return value #10064

Merged
merged 1 commit into from Feb 19, 2020
Merged

bpf: Add test for __ct_lookup return value #10064

merged 1 commit into from Feb 19, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Feb 5, 2020 •
edited by tgraf

Check that __ct_lookup() returns CT_NEW when given tuple wasn't previously connection-tracked.

Fixes: #9303

This change is Reviewable

@pchaigno pchaigno added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Feb 5, 2020
@pchaigno pchaigno requested a review from a team February 5, 2020 15:24
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 5, 2020
@brb
Copy link
Member

brb commented Feb 5, 2020

test-me-please

brb
brb approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@coveralls
Copy link

coveralls commented Feb 5, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 44.533% when pulling 612cdc0 on pr/pchaigno/bpf-ct-lookup-test into 3b6de5f on master.

@joestringer
Copy link
Member

test-me-please

@brb brb added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 6, 2020
@brb
Copy link
Member

brb commented Feb 6, 2020

@pchaigno Please rebase against the latest master. This will fix the conflict and will resolve the CI provisioning issue your CI build is facing.

@pchaigno pchaigno force-pushed the pr/pchaigno/bpf-ct-lookup-test branch from 8275465 to 70b37fa Compare February 6, 2020 17:17
@brb
Copy link
Member

brb commented Feb 6, 2020

test-me-please

1 similar comment
@pchaigno
Copy link
Member Author

pchaigno commented Feb 6, 2020

test-me-please

@joestringer joestringer mentioned this pull request Feb 6, 2020
Closed
14 tasks
@pchaigno pchaigno removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 6, 2020
@aanm aanm added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 7, 2020
@aanm aanm added this to the 1.8 milestone Feb 18, 2020
@aanm aanm added dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. pending-review and removed dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs labels Feb 18, 2020
@aanm
Copy link
Member

aanm commented Feb 18, 2020

@pchaigno needs rebase

@pchaigno
bpf: Add test for __ct_lookup return value
612cdc0 
Check that __ct_lookup returns CT_NEW when given tuple wasn't previously
connection-tracked.

Fixes: #9303

Signed-off-by: Paul Chaignon <paul@isovalent.com>
@pchaigno pchaigno force-pushed the pr/pchaigno/bpf-ct-lookup-test branch from 70b37fa to 612cdc0 Compare February 19, 2020 06:38
@pchaigno pchaigno removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 19, 2020
@pchaigno
Copy link
Member Author

test-me-please

@borkmann borkmann merged commit c402767 into master Feb 19, 2020
1.8.0 automation moved this from In progress to Merged Feb 19, 2020
@borkmann borkmann deleted the pr/pchaigno/bpf-ct-lookup-test branch February 19, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@joestringer joestringer joestringer approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Improve unit tests for conntrack lookup in BPF
7 participants
@pchaigno @brb @coveralls @joestringer @aanm @vadorovsky @borkmann