CI: Local CI runs don't set CILIUM_REGISTRY #10077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to indicate whether to build cilium. This is only relevant when running tests locally and cilium needs to be compiled. Historically, the image has been pushed to k8s1:5000, a repository that runs on the k8s1 host. We now use the global.registry value, piped into CILIUM_REGISTRY, to indicate whether to build cilium. This was being set to a default of "k8s1:5000" thus forcing compile.sh into pulling a prebuilt image from CILIUM_REGISTRY. This is the intended behaviour on CI and when running on managed k8s. In this one case, however, it is incorrect. Signed-off-by: Ray Bejjani <ray@isovalent.com>
raybejjani
added
wip
kind/bug/CI
|
Release note label not set, please set the appropriate release note. |
2 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
test-focus K8sDemosTest* |
|
test-gke K8sDemosTest* |
nebril
approved these changes
Feb 6, 2020
raybejjani
added
release-note/ci
|
test-gke K8sDemosTest* |
1 similar comment
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
1 similar comment
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
7 similar comments
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
test-gke K8sDemosTest* |
|
ok, I'll join the party |
|
test-gke K8sDemosTest* |
aanm
approved these changes
Feb 7, 2020
|
test-gke K8sDemosTest* |
|
@raybejjani @nebril Does this need backporting to v1.7? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to indicate whether to build cilium. This is only relevant when
running tests locally and cilium needs to be compiled. Historically,
the image has been pushed to k8s1:5000, a repository that runs on the
k8s1 host. We now use the global.registry value, piped into
CILIUM_REGISTRY, to indicate whether to build cilium. This was being set
to a default of "k8s1:5000" thus forcing compile.sh into pulling a
prebuilt image from CILIUM_REGISTRY. This is the intended behaviour on
CI and when running on managed k8s. In this one case, however, it is
incorrect.
This change is