daemon: silence log messages during cmdref generation #10090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call genMarkdown as early as possible and extract the cmdref directory directly from viper instead of letting initEnv populate all options first. This avoids log messages related to kvstore when generating cmdref. Also move the os.Exit(0) into daemon_main.go so it is more obvious that the agent exits after generating the command reference. Fixes #10081 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
release-note/misc
|
test-me-please |
aanm
approved these changes
Feb 7, 2020
aanm
added
the
dont-merge/wait-until-release
aanm
removed
the
dont-merge/wait-until-release
aanm
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call genMarkdown as early as possible and extract the cmdref directory
directly from viper instead of letting initEnv populate all options
first. This avoids log messages related to kvstore when generating
cmdref.
Also move the os.Exit(0) into daemon_main.go so it is more obvious that
the agent exits after generating the command reference.
Fixes #10081
Signed-off-by: Tobias Klauser tklauser@distanz.ch
This change is