Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/getting-started: fix docker-compose getting started #10108

Merged
merged 1 commit into from Feb 17, 2020
Merged

examples/getting-started: fix docker-compose getting started #10108

merged 1 commit into from Feb 17, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 10, 2020 •
edited by tgraf

Signed-off-by: André Martins andre@cilium.io

This change is Reviewable

@aanm aanm added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Feb 10, 2020
@aanm aanm requested a review from a team as a code owner February 10, 2020 10:38
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 10, 2020
@aanm aanm added the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 10, 2020
@aanm
Copy link
Member Author

aanm commented Feb 10, 2020

test-me-please

@coveralls
Copy link

coveralls commented Feb 10, 2020 •
edited

Coverage Status

Coverage decreased (-0.02%) to 44.587% when pulling 133bb74 on pr/fix-examples-gettings-started into 54d9254 on master.

@grealish
Copy link

Tested this, and it works when cilium is passed the following argument --enable-ipv6=false as mentioned by @aanm
here's the error when ipv6 is enabled by default

cilium           | level=warning msg="IPv6 is enabled and ip6tables modules could not be initialized" error="could not load module ip6_tables: exit status 1" subsys=iptables                                        
cilium           | level=warning msg="xt_socket kernel module could not be loaded" error="could not load module xt_socket: exit status 1" subsys=iptables

@aanm
examples/getting-started: fix docker-compose getting started
133bb74 
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-examples-gettings-started branch from 959c9e4 to 133bb74 Compare February 11, 2020 12:39
@aanm
Copy link
Member Author

aanm commented Feb 11, 2020

test-me-please

@aanm aanm removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 17, 2020
@aanm aanm merged commit 6d47181 into master Feb 17, 2020
1.8.0 automation moved this from In progress to Merged Feb 17, 2020
@aanm aanm deleted the pr/fix-examples-gettings-started branch February 17, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer requested changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @coveralls @grealish @joestringer