Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client, identity: remove unnecessary guards around delete() #10148

Merged
merged 1 commit into from Feb 12, 2020
Merged

client, identity: remove unnecessary guards around delete() #10148

merged 1 commit into from Feb 12, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Feb 11, 2020 •
edited by tgraf

From https://golang.org/pkg/builtin/#delete

If the map is nil or there is no such element, delete is a no-op.

Signed-off-by: Tobias Klauser tklauser@distanz.ch

This change is Reviewable

@tklauser
client, identity: remove unnecessary guards around delete()
838e3b8 
From https://golang.org/pkg/builtin/#delete

> If the map is nil or there is no such element, delete is a no-op.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs release-note/misc This PR makes changes that have no direct user impact. labels Feb 11, 2020
@tklauser tklauser requested a review from a team as a code owner February 11, 2020 15:02
@tklauser tklauser requested a review from a team February 11, 2020 15:02
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 11, 2020
@tklauser
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 44.609% when pulling 838e3b8 on pr/tklauser/unnecessary-guard-around-delete into c58d749 on master.

@tgraf tgraf removed the dont-merge/wait-until-release Freeze window for current release is blocking non-bugfix PRs label Feb 12, 2020
@tgraf tgraf merged commit b52a982 into master Feb 12, 2020
1.8.0 automation moved this from In progress to Merged Feb 12, 2020
@tgraf tgraf deleted the pr/tklauser/unnecessary-guard-around-delete branch February 12, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@ianvernon ianvernon ianvernon approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @joestringer @ianvernon @tgraf