datapath: Filter out bpftool probes emitting dmesg messages #10164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cilium/linux#1 needs to be accepted first |
vadorovsky
added
sig/datapath
|
Release note label not set, please set the appropriate release note. |
1 similar comment
|
Release note label not set, please set the appropriate release note. |
qmonnet
reviewed
Feb 12, 2020
vadorovsky
force-pushed
the
fix-bpftool-dmesg
branch
from
e821cad
to
8934414
Compare
vadorovsky
force-pushed
the
fix-bpftool-dmesg
branch
2 times, most recently
from
a937ada
to
c09f3cf
Compare
qmonnet
approved these changes
Feb 12, 2020
aanm
added
the
release-note/misc
aanm
added
release-note/bug
aanm
approved these changes
Feb 12, 2020
|
test-me-please |
vadorovsky
force-pushed
the
fix-bpftool-dmesg
branch
from
3826dc5
to
4a476c2
Compare
bpftool feature probes related to trace, perf and write_user helpers are emitting dmesg messages with warnings which may be confusing for operators running Cilium on production environments. After this change, those probes will be not performed. Fixes cilium#10048 Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
Cilium fork of the Linux kernel contains necessary enhancements for bpftool which are not avalavle upstream yet. Ref: cilium#10048 Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
This should be done in packer-ci-build, but to get the fix faster, we install patched bpftool here as a temporary hack... Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
|
test-me-please |
aanm
approved these changes
Feb 13, 2020
joestringer
approved these changes
Feb 13, 2020
pchaigno
added a commit
that referenced
this pull request
Feb 14, 2020
Provisioning of the Vagrant development environment fails due to the
missing forked bpftool:
$ ./contrib/vagrant/start.sh
[...]
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=error msg="Command execution failed" cmd="[bpftool -j feature probe filter_out \\(trace\\|write_user\\)]" error="exit status 255" subsys=probes
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=warning msg="{\"error\":\"expected no more arguments, 'kernel', 'dev', 'macros' or 'prefix', got: 'filter_out'?\"}" subsys=probes
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=fatal msg="could not run bpftool" error="exit status 255" subsys=probes
runtime1: Cilium failed to start
[...]
This provisioning failure was introduced by #10164. Cilium now expects
bpftool to be Cilium's (temporary) forked version, but the VirtualBox VM
has the upstream bpftool. This commit installs the forked bpftool as part
of the Vagrant provisioning.
Signed-off-by: Paul Chaignon <paul@cilium.io>
aanm
pushed a commit
that referenced
this pull request
Feb 14, 2020
Provisioning of the Vagrant development environment fails due to the
missing forked bpftool:
$ ./contrib/vagrant/start.sh
[...]
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=error msg="Command execution failed" cmd="[bpftool -j feature probe filter_out \\(trace\\|write_user\\)]" error="exit status 255" subsys=probes
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=warning msg="{\"error\":\"expected no more arguments, 'kernel', 'dev', 'macros' or 'prefix', got: 'filter_out'?\"}" subsys=probes
runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=fatal msg="could not run bpftool" error="exit status 255" subsys=probes
runtime1: Cilium failed to start
[...]
This provisioning failure was introduced by #10164. Cilium now expects
bpftool to be Cilium's (temporary) forked version, but the VirtualBox VM
has the upstream bpftool. This commit installs the forked bpftool as part
of the Vagrant provisioning.
Signed-off-by: Paul Chaignon <paul@cilium.io>
nebril
pushed a commit
that referenced
this pull request
Feb 17, 2020
[ upstream commit 1810709 ] Provisioning of the Vagrant development environment fails due to the missing forked bpftool: $ ./contrib/vagrant/start.sh [...] runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=error msg="Command execution failed" cmd="[bpftool -j feature probe filter_out \\(trace\\|write_user\\)]" error="exit status 255" subsys=probes runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=warning msg="{\"error\":\"expected no more arguments, 'kernel', 'dev', 'macros' or 'prefix', got: 'filter_out'?\"}" subsys=probes runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=fatal msg="could not run bpftool" error="exit status 255" subsys=probes runtime1: Cilium failed to start [...] This provisioning failure was introduced by #10164. Cilium now expects bpftool to be Cilium's (temporary) forked version, but the VirtualBox VM has the upstream bpftool. This commit installs the forked bpftool as part of the Vagrant provisioning. Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
borkmann
pushed a commit
that referenced
this pull request
Feb 17, 2020
[ upstream commit 1810709 ] Provisioning of the Vagrant development environment fails due to the missing forked bpftool: $ ./contrib/vagrant/start.sh [...] runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=error msg="Command execution failed" cmd="[bpftool -j feature probe filter_out \\(trace\\|write_user\\)]" error="exit status 255" subsys=probes runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=warning msg="{\"error\":\"expected no more arguments, 'kernel', 'dev', 'macros' or 'prefix', got: 'filter_out'?\"}" subsys=probes runtime1: Feb 13 17:26:23 runtime1 cilium-agent[20863]: level=fatal msg="could not run bpftool" error="exit status 255" subsys=probes runtime1: Cilium failed to start [...] This provisioning failure was introduced by #10164. Cilium now expects bpftool to be Cilium's (temporary) forked version, but the VirtualBox VM has the upstream bpftool. This commit installs the forked bpftool as part of the Vagrant provisioning. Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.0-rc4
joestringer
moved this from Needs backport from master
to Backport done to v1.7
in 1.7.0-final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpftool feature probes related to trace, perf and write_user helpers are
emitting dmesg messages with warnings which may be confusing for
operators running Cilium on production environments. After this change,
those probes will be not performed.
Fixes #10048
Signed-off-by: Michal Rostecki mrostecki@opensuse.org
This change is