Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Adjust documentation to renamed cilium-sysdump tool #10165

Merged
merged 1 commit into from Feb 24, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Feb 12, 2020

The PR cilium/cilium-sysdump#76 has renamed the cluster-diagnosis tool to
cilium-sysdump and simplified it. Adjust the documentation accordingly.


This change is Reviewable

@tgraf tgraf added pending-review area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Feb 12, 2020
@tgraf tgraf requested review from a team as code owners February 12, 2020 12:07
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

2 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 12, 2020
@tgraf tgraf added the release-note/misc This PR makes changes that have no direct user impact. label Feb 12, 2020
@tgraf tgraf force-pushed the pr/tgraf/rename-cilium-sysdump branch from 45ff28c to 7baf6d0 Compare February 12, 2020 12:08
Documentation/troubleshooting.rst Outdated Show resolved Hide resolved
Documentation/troubleshooting.rst Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage decreased (-0.008%) to 45.517% when pulling 8b7c519 on pr/tgraf/rename-cilium-sysdump into 321b147 on master.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also backport this to older branches, right?

@aanm aanm added this to the 1.8 milestone Feb 18, 2020
@tgraf tgraf force-pushed the pr/tgraf/rename-cilium-sysdump branch from 7baf6d0 to bd605c4 Compare February 19, 2020 17:13
@tgraf tgraf changed the title doc: Adjust documentation to renamed cilium-sysdump tool [DO NOT MERGE] doc: Adjust documentation to renamed cilium-sysdump tool Feb 19, 2020
@tgraf
Copy link
Member Author

tgraf commented Feb 19, 2020

Waiting for next release of https://github.com/cilium/cilium-sysdump

@tgraf
Copy link
Member Author

tgraf commented Feb 19, 2020

@tgraf
Copy link
Member Author

tgraf commented Feb 19, 2020

Confirmed that this is working:

curl -LO https://github.com/cilium/cilium-sysdump/releases/latest/download/cilium-sysdump.zip

@tgraf tgraf changed the title [DO NOT MERGE] doc: Adjust documentation to renamed cilium-sysdump tool doc: Adjust documentation to renamed cilium-sysdump tool Feb 19, 2020
@tgraf
Copy link
Member Author

tgraf commented Feb 19, 2020

test-docs-please

EDIT: Complained about unknown sysdump word. Fixed

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.1 Feb 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.6.7 Feb 19, 2020
@tgraf tgraf force-pushed the pr/tgraf/rename-cilium-sysdump branch from bd605c4 to fdfdc5d Compare February 19, 2020 20:28
@tgraf
Copy link
Member Author

tgraf commented Feb 19, 2020

test-docs-please

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit below.

Documentation/troubleshooting.rst Show resolved Hide resolved
The PR cilium/cilium-sysdump/pull/76 has renamed the cluster-diagnosis tool to
cilium-sysdump and simplified it. Adjust the documentation accordingly.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/rename-cilium-sysdump branch from fdfdc5d to 8b7c519 Compare February 24, 2020 15:04
@tgraf
Copy link
Member Author

tgraf commented Feb 24, 2020

test-docs-please

@tgraf tgraf merged commit 9d8114f into master Feb 24, 2020
1.8.0 automation moved this from In progress to Merged Feb 24, 2020
@tgraf tgraf deleted the pr/tgraf/rename-cilium-sysdump branch February 24, 2020 15:52
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.1 Feb 27, 2020
@brb brb mentioned this pull request Feb 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.6 in 1.6.7 Feb 27, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.1 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.6.7
Backport done to v1.6
1.7.1
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants