make: consistently use $(GO) to invoke the Go tool #10181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise when building with e.g. GO=go1.14rc1 make, the version log message still shows: level=info msg="Cilium 1.7.90 7051378bf234 2020-02-11T11:05:47+01:00 go version go1.13.8 linux/amd64" subsys=daemon while e.g. `go version /usr/bin/cilium-agent` correctly shows: /usr/bin/cilium-agent: go1.14rc1 Also use $(GO) when checking for `-mod=vendor0` support. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
release-note/misc
|
test-me-please |
joestringer
approved these changes
Feb 13, 2020
aanm
approved these changes
Feb 19, 2020
|
test-me-please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when building with e.g. GO=go1.14rc1 make, the version log
message still shows:
level=info msg="Cilium 1.7.90 7051378bf234 2020-02-11T11:05:47+01:00 go version go1.13.8 linux/amd64" subsys=daemon
while e.g.
go version /usr/bin/cilium-agentcorrectly shows:/usr/bin/cilium-agent: go1.14rc1
Also use $(GO) when checking for
-mod=vendorsupport.Signed-off-by: Tobias Klauser tklauser@distanz.ch
This change is