Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: remove unused type rulesManager #10188

Merged
merged 1 commit into from Feb 19, 2020
Merged

daemon: remove unused type rulesManager #10188

merged 1 commit into from Feb 19, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Feb 14, 2020 •
edited by tgraf

It's been unused since commit 5882053 ("datapath: make Datapath an
IptablesManager")

Signed-off-by: Tobias Klauser tklauser@distanz.ch

This change is Reviewable

@tklauser
daemon: remove unused type rulesManager
b33ee64 
It's been unused since commit 5882053 ("datapath: make `Datapath`
an `IptablesManager`")

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser requested a review from a team February 14, 2020 13:19
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 14, 2020
@tklauser tklauser added area/daemon Impacts operation of the Cilium daemon. kind/cleanup This includes no functional changes. pending-review release-note/misc This PR makes changes that have no direct user impact. labels Feb 14, 2020
@tklauser
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 44.497% when pulling b33ee64 on pr/tklauser/remove-rulesmanager into 1810709 on master.

@tklauser tklauser added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed pending-review labels Feb 17, 2020
@aanm aanm added this to the 1.8 milestone Feb 18, 2020
@aanm aanm merged commit 0dec7e6 into master Feb 19, 2020
1.8.0 automation moved this from In progress to Merged Feb 19, 2020
@aanm aanm deleted the pr/tklauser/remove-rulesmanager branch February 19, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @coveralls @brb @pchaigno @aanm