agent: Remove awareness of IPv4 cluster-range #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgraf
added
the
release-note/minor
tklauser
reviewed
Feb 14, 2020
While operating in direct-routing mode (`--tunnel=disabled`), traffic with a destination address matching a particular CIDR is automatically excluded from being masqueraded. So far, this CIDR consisted of `<alloc-cidr>/<size>` where the size could be set with the option `--ipv4-cluster-cidr-mask-size`. This was not always desirable and limiting, therefore Cilium 1.6 had already introduced the option `--native-routing-cidr` allowing to explicitly specify the CIDR for native routing. With Cilium 1.8, the option `--ipv4-cluster-cidr-mask-size` is being deprecated and all users must use the option `--native-routing-cidr` instead. Updates: #9919 Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pr/tgraf/remove-ipv4-cluster-dependency
branch
from
3165035
to
ad81272
Compare
|
test-me-please |
joestringer
approved these changes
Feb 18, 2020
|
test-me-please |
aanm
approved these changes
Feb 19, 2020
|
test-me-please |
gandro
added a commit
to gandro/cilium
that referenced
this pull request
Jan 10, 2022
The `single-cluster-route` flag was intended to instruct Cilium to use a single route covering the entire cluster CIDR to point to the `cilium_host` interface in tunnel mode, instead of per-host or per-endpoint routes. However, the underlying concept of a cluster prefix used for routing was removed in PR cilium#10194. It seems the `single-cluster-route` flag was likely even broken prior to that and accidentally used the per-node mask instead of the per-cluster mask for the route. In summary, this flag has not been functional for almost two years. As no one seems to have noticed, it should be safe to remove this defunct flag without a deprecation period. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While operating in direct-routing mode (
--tunnel=disabled), traffic with adestination address matching a particular CIDR is automatically excluded from
being masqueraded. So far, this CIDR consisted of
<alloc-cidr>/<size>wherethe size could be set with the option
--ipv4-cluster-cidr-mask-size. This wasnot always desirable and limiting, therefore Cilium 1.6 had already introduced
the option
--native-routing-cidrallowing to explicitly specify the CIDR fornative routing. With Cilium 1.8, the option
--ipv4-cluster-cidr-mask-sizeisbeing deprecated and all users must use the option
--native-routing-cidrinstead.
Updates: #9919
This change is