Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clustermesh: Ignore ..data directory of secrets mount #10200

Merged
merged 1 commit into from Feb 19, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Feb 14, 2020

Skip any directory present in the config directory to avoid warnings like these:

level=warning msg="Unable to establish etcd connection to remote cluser" clusterName=..data config=/var/lib/cilium/clustermesh/..data error="read /var/lib/cilium/clustermesh/..data: is a directory" kvstoreErr="<nil>" kvstoreStatus= subsys=clustermesh

Fixes: #6408


This change is Reviewable

Skip any directory present in the config directory to avoid warnings like these:
```
level=warning msg="Unable to establish etcd connection to remote cluser" clusterName=..data config=/var/lib/cilium/clustermesh/..data error="read /var/lib/cilium/clustermesh/..data: is a directory" kvstoreErr="<nil>" kvstoreStatus= subsys=clustermesh
```

Fixes: #6408

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Feb 14, 2020
@tgraf tgraf requested a review from a team as a code owner February 14, 2020 21:59
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 14, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.493% when pulling 08c7faf on pr/tgraf/clustermesh-ignore-dir into 5e01fb6 on master.

@tgraf
Copy link
Member Author

tgraf commented Feb 17, 2020

test-me-please

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't the .. prefix work here?

@aanm aanm added this to the 1.8 milestone Feb 18, 2020
@aanm aanm merged commit 47531ad into master Feb 19, 2020
1.8.0 automation moved this from In progress to Merged Feb 19, 2020
@aanm aanm deleted the pr/tgraf/clustermesh-ignore-dir branch February 19, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

clustermesh: Directory is mistaken for
4 participants