test: Reduce length of log filenames #10213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
pending-review
area/CI
|
test-me-please |
With some filesystems (e.g., ecryptfs), the maximum filename length is
lower than 255, that of ext4. On these filesystems, the tests fail with
the following error because log filenames are too long:
K8sPolicyTest Basic Test Redirects traffic to proxy when no policy is applied with proxy-visibility annotation Tests HTTP proxy visibility without policy
at /cilium/cilium/test/ginkgo-ext/scopes.go:430
[Could not read monitor log
Expected
<*os.PathError | 0xc000e1fec0>: {
Op: "open",
Path: "test_results/117-/K8sPolicyTest_Basic_Test_Redirects_traffic_to_proxy_when_no_policy_is_applied_with_proxy-visibility_annotation_Tests_HTTP_proxy_visibility_without_policy/monitor-13f3cf9b-4f30-11ea-b222-60f262b6c493.log",
Err: 0x24,
}
to be nil]
This commit updates the name of the tests (from which the log filename is
derived) to be consistent with other tests' names.
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/fix-long-test-logfile-names
branch
from
ff89671
to
34b028a
Compare
|
test-me-please |
aanm
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some filesystems (e.g., ecryptfs), the maximum filename length is lower than 255, that of ext4. On these filesystems, the tests fail with the following error because log filenames are too long:
This pull request updates the name of the test, from which the log filename is derived, to be consistent with other tests' names.
This change is