Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Envoy: Update to 1.13.1 #10222

Merged
merged 1 commit into from Mar 10, 2020
Merged

Envoy: Update to 1.13.1 #10222

merged 1 commit into from Mar 10, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Feb 17, 2020 •
edited

Update Envoy to the latest release to be ready for Istio 1.5 update.

Cilium host proxy has has been updated to Envoy release 1.13.1.

This change is Reviewable

@jrajahalme jrajahalme added wip area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. labels Feb 17, 2020
@jrajahalme jrajahalme added this to the 1.8 milestone Feb 17, 2020
@jrajahalme jrajahalme requested review from a team as code owners February 17, 2020 22:09
@jrajahalme jrajahalme added this to In progress in 1.8.0 via automation Feb 17, 2020
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

1 similar comment
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@jrajahalme jrajahalme added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Feb 17, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/envoy-update-1.13.0 branch from 29fff08 to cd64ec3 Compare February 18, 2020 23:03
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Feb 18, 2020 •
edited

Coverage Status

Coverage decreased (-0.007%) to 45.609% when pulling 61780e9 on pr/jrajahalme/envoy-update-1.13.0 into ed74481 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.0-final Feb 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.6.7 Feb 19, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.5.13 Feb 19, 2020
@jrajahalme jrajahalme added the dont-merge/preview-only Only for preview or testing, don't merge it. label Feb 19, 2020
@joestringer joestringer removed this from Needs backport from master in 1.7.0-final Feb 19, 2020
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/envoy-update-1.13.0 branch from cd64ec3 to 96c176f Compare February 19, 2020 21:18
@jrajahalme jrajahalme removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Feb 19, 2020
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

Looks like an unrelated failure in Kafka test teardown:

14:35:41  • Failure in Spec Teardown (AfterEach) [16.932 seconds]
14:35:41  RuntimeKafka
14:35:41  /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/runtime-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:395
14:35:41    Kafka Policy Role Ingress [AfterEach]
14:35:41    /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/runtime-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:430
14:35:41  
14:35:41    Expected command: sudo cilium config ConntrackLocal=false 
[2020-02-19T22:35:41.081Z]   To succeed, but it failed:
[2020-02-19T22:35:41.081Z]   Exitcode: 1 
[2020-02-19T22:35:41.081Z]   Stdout:
[2020-02-19T22:35:41.081Z]    	 
[2020-02-19T22:35:41.081Z]   Stderr:
[2020-02-19T22:35:41.081Z]    	 Error: Error while retrieving configuration: Get http:///var/run/cilium/cilium.sock/v1/config: dial unix /var/run/cilium/cilium.sock: connect: connection refused
[2020-02-19T22:35:41.081Z]   	 Is the agent running?
[2020-02-19T22:35:41.081Z]   	 
[2020-02-19T22:35:41.081Z]

Looks like Cilium may have crashed, causing sudo cilium config to fail.

@jrajahalme
Copy link
Member Author

Letting the failing test run finish to get the artifacts.

@aanm aanm added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 24, 2020
@joestringer joestringer removed this from Needs backport from master in 1.6.7 Mar 5, 2020
@joestringer joestringer removed this from Needs backport from master in 1.5.13 Mar 5, 2020
@joestringer joestringer added this to Needs backport from master in 1.6.8 Mar 5, 2020
@joestringer joestringer added this to Needs backport from master in 1.7.2 Mar 5, 2020
@joestringer joestringer added this to Needs backport from master in 1.5.14 Mar 5, 2020
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/envoy-update-1.13.0 branch from 96c176f to c43632f Compare March 9, 2020 18:39
@jrajahalme jrajahalme changed the title Envoy: Update to 1.13.0 Envoy: Update to 1.13.1 Mar 9, 2020
@jrajahalme jrajahalme removed dont-merge/preview-only Only for preview or testing, don't merge it. needs-backport/1.5 labels Mar 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.6.8 Mar 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.7.2 Mar 9, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.5.14 Mar 9, 2020
@jrajahalme jrajahalme removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 9, 2020
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/envoy-update-1.13.0 branch from c43632f to 89bc29a Compare March 9, 2020 19:27
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Envoy: Update to 1.13.1
61780e9 
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/envoy-update-1.13.0 branch from 89bc29a to 61780e9 Compare March 9, 2020 20:23
@jrajahalme
Copy link
Member Author

test-me-please

@aanm aanm merged commit 36d299e into master Mar 10, 2020
1.8.0 automation moved this from In progress to Merged Mar 10, 2020
@aanm aanm deleted the pr/jrajahalme/envoy-update-1.13.0 branch March 10, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybejjani raybejjani raybejjani approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.8.0
  
Merged
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrajahalme @coveralls @raybejjani @aanm