Embed Hubble #10238
Merged
Embed Hubble #10238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release note label not set, please set the appropriate release note. |
houndci-bot
reviewed
Feb 19, 2020
houndci-bot
reviewed
Feb 19, 2020
houndci-bot
reviewed
Feb 19, 2020
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
2 times, most recently
from
70ffdfc
to
de770f7
Compare
aanm
added
pending-review
release-note/major
aanm
reviewed
Feb 19, 2020
aanm
added
dont-merge/waiting-for-upstream
|
waiting on #9924 to be merged |
tgraf
requested changes
Feb 19, 2020
|
thanks for your feedback @tgraf , i'll rebase and then address your comments. |
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
2 times, most recently
from
2f0b4a6
to
d6e18c8
Compare
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
bc4ec4b
to
7edb371
Compare
|
test-me-please |
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
7edb371
to
12ea5c4
Compare
|
test-me-please |
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
12ea5c4
to
9e4f0c9
Compare
|
test-me-please |
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
9e4f0c9
to
be24fd4
Compare
|
test-me-please |
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
be24fd4
to
6542c71
Compare
|
test-me-please |
rolinh
approved these changes
Mar 3, 2020
|
test-me-please |
1 similar comment
|
test-me-please |
aanm
requested changes
Mar 4, 2020
Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Hubble needs to access this function to implement the IPGetter interface: https://github.com/cilium/hubble/blob/04ab72591faca62a305ce0715108876167182e04/pkg/parser/getters/getters.go#L47 Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Hubble needs to be able to look up service namespace/name by address to implement the ServiceGetter interface: https://github.com/cilium/hubble/blob/04ab72591faca62a305ce0715108876167182e04/pkg/parser/getters/getters.go#L52 Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
- Implement a monitor listener that sends monitor events to Hubble. - Export RegisterNewListener and Monitor so that Daemon can register Hubble as a monitor listener. Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Implement all the getter interfaces that Hubble uses to access Cilium state: https://github.com/cilium/hubble/blob/04ab72591faca62a305ce0715108876167182e04/pkg/parser/getters/getters.go Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Add options to launch Hubble with the following configuration parameters:
- hubble-listen-addresses:
List of IP addresses for Hubble server to listen to. Hubble is disabled
if this list is empty. It also limits the addresses to be Unix domain
socket for now.
- hubble-flow-buffer-size:
Maximum number of flows in Hubble's buffer.
- hubble-event-queue-size:
Buffer size of the channel to receive monitor events.
- hubble-metrics-server:
Address to serve Hubble metrics on. The metrics server is disabled if
this string is empty.
- hubble-metrics:
List of Hubble metrics to enable.
Ref #9925
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/hubble3
branch
from
6542c71
to
8dffb1f
Compare
|
test-me-please |
|
fixed the etcd version in go.mod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7 commits:
listener refactoring, there is a separate PR here.RebasedThis change is