Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GKE CI: Fix K8sDatapathConfig* tests #10259

Merged
merged 3 commits into from Feb 25, 2020
Merged

GKE CI: Fix K8sDatapathConfig* tests #10259

merged 3 commits into from Feb 25, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Feb 20, 2020 •
edited

  • IPv6 is not enabled on GKE for now so some test expectations need to be adjusted
  • autoDirectNodeRoutes is not compatible so tests must be disabled

Fixes: #10030
Fixes: #10026

This change is Reviewable

@tgraf tgraf added kind/bug This is a bug in the Cilium logic. area/CI Continuous Integration testing issue or flake release-note/bug This PR fixes an issue in a previous release of Cilium. labels Feb 20, 2020
@tgraf tgraf requested a review from a team as a code owner February 20, 2020 13:20
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 20, 2020
@tgraf tgraf mentioned this pull request Feb 20, 2020
Closed
@tgraf
Copy link
Member Author

tgraf commented Feb 20, 2020 •
edited

test-gke K8sDatapathConfig*

hudson.plugins.git.GitException: Failed to fetch from https://github.com/cilium/cilium.git

This was referenced Feb 20, 2020
Closed
Closed
@tgraf
Copy link
Member Author

tgraf commented Feb 20, 2020 •
edited

test-gke K8sDatapathConfig*

EDIT: Leftover namespaces caused all tests to fail

@coveralls
Copy link

coveralls commented Feb 20, 2020 •
edited

Coverage Status

Coverage decreased (-0.005%) to 45.521% when pulling 65f78eb on pr/tgraf/gke-fixes into 321b147 on master.

@tgraf
Copy link
Member Author

tgraf commented Feb 20, 2020

test-me-please

@tgraf
Copy link
Member Author

tgraf commented Feb 21, 2020

test-gke K8sDatapathConfig*

@tgraf
Copy link
Member Author

tgraf commented Feb 21, 2020 •
edited

test-me-please

All tests passed except Suite-runtime.RuntimeMonitorTest With Sample Containers Cilium monitor event types which failed due to a known FOUND DEADLOCK flake. Definitely unrelated to these changes.

@tgraf
Copy link
Member Author

tgraf commented Feb 21, 2020

test-gke K8sDatapathConfig*

@nebril
Copy link
Member

nebril commented Feb 21, 2020 •
edited by tgraf

test-gke K8sDatapathConfig*

EDIT: Only a flake failed, the tests which consistently failed are now succeeding.

@tgraf
test: Consider IPv6 enablement when checking tunnel map entries
168e813 
Depending on whether IPv6 is enabled or not, the number of tunnel map entries will vary

Fixes: #10026

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Skip autoDirectNodeRoutes on GKE
4286378 
GKE on GCE dosn't guarantee a flat L2 network so autoDirectNodeRoute tests need
to be disabled.

Fixes: #10030

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
test: Disable Geneve encapsulation tests on GKE
65f78eb 
GKE currently doesn't support Geneve:
level=warning msg="+ ip link add name cilium_geneve address a6:04:9c:c0:d2:5b mtu 1460 type geneve external" subsys=datapath-loader
level=warning msg="RTNETLINK answers: Operation not supported" subsys=datapath-loader

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
Copy link
Member Author

tgraf commented Feb 24, 2020

test-gke K8sDatapathConfig*

1 similar comment
@tgraf
Copy link
Member Author

tgraf commented Feb 24, 2020

test-gke K8sDatapathConfig*

@tgraf tgraf merged commit 37dd01d into master Feb 25, 2020
1.8.0 automation moved this from In progress to Merged Feb 25, 2020
@tgraf tgraf deleted the pr/tgraf/gke-fixes branch February 25, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Triage/Fixup DirectRouting tests on GKE CI: Fixup encapsulation tests on GKE
4 participants
@tgraf @coveralls @nebril @aanm