Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix nightly upgrade test #10306

Merged
merged 2 commits into from Mar 2, 2020
Merged

test: fix nightly upgrade test #10306

merged 2 commits into from Mar 2, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 24, 2020 •
edited by tgraf

The order of the arguments are switched which makes the upgrade tests
from failing in the nightly tests.

Signed-off-by: André Martins andre@cilium.io

This change is Reviewable

@aanm aanm requested a review from a team as a code owner February 24, 2020 14:23
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 24, 2020
@aanm aanm added the release-note/ci This PR makes changes to the CI. label Feb 24, 2020
@aanm
Copy link
Member Author

aanm commented Feb 24, 2020

test-focus NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 24, 2020

test-focus NightlyExamples.*

@coveralls
Copy link

coveralls commented Feb 24, 2020 •
edited

Coverage Status

Coverage decreased (-0.01%) to 45.518% when pulling 5f5e63c8fc556543b5090d894459834b411178d8 on pr/fix-nightly-upgrade-test into b676c4c on master.

@aanm
Copy link
Member Author

aanm commented Feb 24, 2020

@nebril it seems the upgrade tests failed with the following error:

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:430
cannot apply dempo application
Expected command: kubectl apply --force=false -f  
To succeed, but it failed:
Exitcode: 1 
Stdout:
 	 
Stderr:
 	 Error: flag needs an argument: 'f' in -f
	 See 'kubectl apply --help' for usage.
	 

/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.11-gopath/src/github.com/cilium/cilium/test/k8sT/Nightly.go:398

Is this because the nightly upgrade tests are not setting the demoPath string similar to the way it's done in

cilium/test/k8sT/Updates.go

Line 62 in 40657fa

demoPath = helpers.ManifestGet(kubectl.BasePath(), "demo.yaml")

@nebril
Copy link
Member

nebril commented Feb 24, 2020

test-nightly NightlyExamples.*

1 similar comment
@nebril
Copy link
Member

nebril commented Feb 24, 2020

test-nightly NightlyExamples.*

@aanm aanm force-pushed the pr/fix-nightly-upgrade-test branch from ecabe70 to a19549c Compare February 25, 2020 14:24
@aanm
Copy link
Member Author

aanm commented Feb 25, 2020

test-nightly NightlyExamples.*

1 similar comment
@nebril
Copy link
Member

nebril commented Feb 25, 2020

test-nightly NightlyExamples.*

@nebril
Copy link
Member

nebril commented Feb 25, 2020

test-nightly NightlyExamples.*

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

1 similar comment
@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 26, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 27, 2020

test-nightly NightlyExamples

1 similar comment
@nebril
Copy link
Member

nebril commented Feb 27, 2020

test-nightly NightlyExamples

@nebril nebril force-pushed the pr/fix-nightly-upgrade-test branch 2 times, most recently from df9dea0 to 1b0dae7 Compare February 28, 2020 11:53
@nebril
Copy link
Member

nebril commented Feb 28, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 28, 2020

test-nightly NightlyExamples

aanm and others added 2 commits February 28, 2020 16:06
@aanm @nebril
test: fix nightly upgrade test
ab0796e 
The order of the arguments are switched which makes the upgrade tests
from failing in the nightly tests.

Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Add focus for nightly jenkinsfile
b73f544 
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member

nebril commented Feb 28, 2020

test-nightly NightlyExamples

@nebril
Copy link
Member

nebril commented Feb 28, 2020

test-me-please

1 similar comment
@nebril
Copy link
Member

nebril commented Mar 2, 2020

test-me-please

@nebril
Copy link
Member

nebril commented Mar 2, 2020

hit a flake, rerunning regular tests

@raybejjani raybejjani merged commit fb4f548 into master Mar 2, 2020
1.8.0 automation moved this from In progress to Merged Mar 2, 2020
@raybejjani raybejjani deleted the pr/fix-nightly-upgrade-test branch March 2, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raybejjani raybejjani raybejjani approved these changes

Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanm @nebril @coveralls @raybejjani