Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing words to spelling word list #10328

Merged
merged 1 commit into from Feb 25, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Feb 25, 2020

These were added by #10203


This change is Reviewable

These were added by #10203

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Feb 25, 2020
@tklauser tklauser requested a review from a team as a code owner February 25, 2020 09:09
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 25, 2020
@tklauser
Copy link
Member Author

test-docs-please

@@ -173,6 +174,7 @@ balancers
battlestation
bcc
behaviour
benefitting
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may also be spelled benefiting, both are fine according to https://www.merriam-webster.com/dictionary/benefit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably stick to one though, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. There's no occurrence of either one in Documentation/ yet before #10203, so I guess we stick to benefitting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benefiting looks more common, but I don't have a strong opinion either way :-)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 45.475% when pulling 28a926a on pr/tklauser/doc-add-words-to-spelling into 9e30278 on master.

@tgraf tgraf merged commit fd55438 into master Feb 25, 2020
1.8.0 automation moved this from In progress to Merged Feb 25, 2020
@tgraf tgraf deleted the pr/tklauser/doc-add-words-to-spelling branch February 25, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants