Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing newlines at end of file #10334

Merged
merged 1 commit into from Feb 26, 2020
Merged

Fix missing newlines at end of file #10334

merged 1 commit into from Feb 26, 2020

Conversation

maxbischoff
Copy link
Contributor

@maxbischoff maxbischoff commented Feb 25, 2020 •
edited by tgraf

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

This change is Reviewable

@maxbischoff
Fix missing newlines at end of file
3096caa 
Signed-off-by: Maximilian Bischoff <maximilian.bischoff@inovex.de>
@maxbischoff maxbischoff requested a review from a team February 25, 2020 15:31
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 25, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.484% when pulling 3096caa on maxbischoff:fix-missing-newlines into 37dd01d on cilium:master.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Feb 26, 2020
@tklauser
Copy link
Member

test-me-please

@tgraf tgraf merged commit e4cdb26 into cilium:master Feb 26, 2020
1.8.0 automation moved this from In progress to Merged Feb 26, 2020
@maxbischoff maxbischoff deleted the fix-missing-newlines branch February 27, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxbischoff @coveralls @tklauser @tgraf