New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger generated APIs from master #10336
Swagger generated APIs from master #10336
Conversation
Commit c4b8d0c866522970ad96bde6b430ab8f866e01d0 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin |
Release note label not set, please set the appropriate release note. |
1 similar comment
Release note label not set, please set the appropriate release note. |
c4b8d0c
to
a81d1ea
Compare
8aaa177
to
f411adc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing this! At first glance this seems good, just one comment for the last couple of files below.
f411adc
to
d6a11c3
Compare
Alright.... |
Obviously there have been some changes to code and swagger declarations which weren't built. * Commands run: `make generate-api` & `make generate-health-api`. * Then removed `api/v1/health/models/health_response.go` on request of @aanm. * Unstaged swagger removed `// +k8s:deepcopy-gen=true` lines on request of @joestringer. * Removed api/v1/health/server/server.go * api/v1/server/server.go due to build failure, and odd import changes: https://github.com/cilium/cilium/pull/10336/files/f411adcbf09a9cf827438a59c189bc8cbe62f54c#r384055153 Related: cilium#10116 Signed-off-by: Joshua Roppo joshroppo@gmail.com
d6a11c3
to
d622306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What can we do to not miss these ones? 🤔
test-me-please |
test-me-please EDIT: Woops, github was out of sync so I accidentally re-triggered. |
@aanm the failure of swagger to produce breaking changes could be caught by running the swagger generation, and then running Running the swagger generation on every PR would expose the issues which my first PR uncovered. I'll re-list the issues uncovered in this yak shaving exercise:
Those are all the issues I know of at this point. |
Obviously there have been some changes to code and swagger declarations
which weren't built.
Commands run:
make generate-api
&make generate-health-api
&git add api*
. That's it.Backstory
These changes were noticed when making a modification to the
server.gotmpl
file for #10116. Thus creating a requirement to separate API master code, from what was being changed for thesyscall
package removal.@aanm asked me to build all of the swagger generated code from master so the diff between #10158 was limited to only the
syscall
->unix
package changes.Related: #10116
Signed-off-by: Joshua Roppo joshroppo@gmail.com
This change is