New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
early spring cleanup helper prep for xdp #10344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove __inline__ treewide and add a compiler.h library where we can place misc compiler related things in a central place. Signed-off-by: Zhiyuan Hou <zhiyuan2048@linux.alibaba.com> [ Daniel: picking up and extending Zhiyuan's PR #10017 after rebase ] Co-developed-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Get a bit of order in here. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
It's not used yet, but to make comments consistent to CTX_ACT_ codes. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
added
pending-review
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
kind/cleanup
This includes no functional changes.
labels
Feb 26, 2020
Release note label not set, please set the appropriate release note. |
3 similar comments
Release note label not set, please set the appropriate release note. |
Release note label not set, please set the appropriate release note. |
Release note label not set, please set the appropriate release note. |
borkmann
added
area/misc
Impacts miscellaneous areas of the code not otherwise owned by another area.
release-note/misc
This PR makes changes that have no direct user impact.
labels
Feb 26, 2020
test-me-please |
borkmann
force-pushed
the
pr/header-cleanup
branch
2 times, most recently
from
February 26, 2020 14:13
7ee1ca9
to
2c0b3fb
Compare
test-me-please |
borkmann
force-pushed
the
pr/header-cleanup
branch
from
February 26, 2020 14:20
2c0b3fb
to
dd4b573
Compare
test-me-please |
Early spring cleanup to make them more useful and later better extensible for XDP. Also remove iproute2 header which is not needed anymore. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
force-pushed
the
pr/header-cleanup
branch
from
February 26, 2020 14:22
dd4b573
to
743f295
Compare
test-me-please |
brb
approved these changes
Feb 26, 2020
qmonnet
approved these changes
Feb 26, 2020
joestringer
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/misc
Impacts miscellaneous areas of the code not otherwise owned by another area.
kind/cleanup
This includes no functional changes.
release-note/misc
This PR makes changes that have no direct user impact.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given we've been refactoring the whole BPF code base via #10333, perform some more cleanup including rebase of #10017 while at it, so others only need to rebase once. See commit msg @brb
This change is