Fix eks restart pods helm #10351
Merged
Fix eks restart pods helm #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release note label not set, please set the appropriate release note. |
jrajahalme
requested changes
Feb 26, 2020
|
Also add the description to the commit message, thanks! |
aanm
requested changes
Feb 27, 2020
aanm
added
pending-review
release-note/bug
|
@jrajahalme I added the original issue from the first pull request |
tom-hadlaw-hs
force-pushed
the
fix-eks-restart-pods
branch
from
e921115
to
70da631
Compare
Fixes issue where Helm breaks the node init script when restartPods is enabled. Fixes issue where removing container can cause issues with Kubelet scheduling. fixes: cilium#9571 Signed-off-by: Tom Hadlaw <thomas.hadlaw@hootsuite.com>
tom-hadlaw-hs
force-pushed
the
fix-eks-restart-pods
branch
from
70da631
to
e611448
Compare
aanm
approved these changes
Mar 4, 2020
|
test-me-please |
|
test-me-please |
tgraf
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Hadlaw thomas.hadlaw@hootsuite.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Follow up bugfix's for my previous pull request. One problem is that helm actually breaks the docker
--formatargument value as it considers it a template value. This causes the conditional to always be false and for the container restart to never happen on EKS nodes.Secondly, upon further testing, it seems like kubelet can fail due if the container is removed: (
rpc error: code = Unknown desc = unable to inspect docker image ...).I'm not exactly sure why this didn't happen during my first round of testing but I propose to just kill the container and let Kubelet manage the remaining container state (docker kill just sends sigkill to the container process, wheraes rm removes all the container state as well). The container does get cleaned up afterwards.
fixes: #9571
This change is