daemon: Make build depend on Makefiles and Dockerfile #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-build may be needed due to changes in Makefiles or the Dockerfile. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
pending-review
area/misc
|
test-me-please |
aanm
reviewed
Feb 27, 2020
| @@ -4,7 +4,7 @@ include ../Makefile.defs | |||
| TARGET=cilium-agent | |||
| LINKS=cilium-node-monitor | |||
| SOURCES := $(shell find ../api ../common ../daemon ../pkg . \( -name '*.go' ! -name '*_test.go' \)) | |||
| $(TARGET): $(SOURCES) | |||
| $(TARGET): $(SOURCES) ../Dockerfile ../Makefile ../Makefile.defs Makefile | |||
There was a problem hiding this comment.
This is odd, why would a change in the Dockerfile would need to make the binary to be rebuild? Ah, is that in the case that when we are creating a Dockerimage the binary is not re-compiled in case it already exists?
There was a problem hiding this comment.
Yes. For example when updating the Envoy SHA dependency.
aanm
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-build may be needed due to changes in Makefiles or the Dockerfile.
This change is