Improve pod restarts on GKE #10377
Merged
Improve pod restarts on GKE #10377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pod restart from node init supposed to happen once kubelet is reconfigured, but order is opposite in the helm chart. It's also unnecessary to hold off cilium agent pod till pods are restarted. This patch moves pod restart to the last operation in node init. This patch also fixes typo in the GKE docs: 'global.restartPods' -> 'nodeinit.restartPods'. Signed-off-by: Arthur Evstifeev <aevstifeev@gitlab.com>
|
Release note label not set, please set the appropriate release note. |
joestringer
added
the
release-note/bug
aanm
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
That's a good point. @raybejjani @nebril are we using this file in gke testing? If yes should we trigger a CI run for GKE?
|
test-me-please |
tgraf
approved these changes
Feb 28, 2020
|
test-gke |
|
Failures in this PR: Compare with current GKE stability on master: |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pod restart from node init supposed to happen once kubelet is
reconfigured, but order is opposite in the helm chart. It's also
unnecessary to hold off cilium agent pod till pods are restarted. This
patch moves pod restart to the last operation in node init. This patch
also fixes typo in the GKE docs: 'global.restartPods' ->
'nodeinit.restartPods'.
This change is