test: Install Helm 3 #10378
Merged
test: Install Helm 3 #10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
pending-review
area/CI-improvement
|
test-me-please |
aanm
requested changes
Feb 28, 2020
There was a problem hiding this comment.
@jrajahalme the upgrade guide should reflect the steps executed in the upgrade guide here: https://docs.cilium.io/en/v1.7/install/upgrade/ we require helm 3 to installed in order for the upgrade guide to be successful.
|
@aanm If Helm 3 is required, then why we insist on installing Helm 2 in |
Helm 3 is required so install it rather than Helm 2. Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
Running preflight daemonset can fail due to image pull error, if trying to pull the "cilium" image:
$ kubectl get pods --all-namespaces
kube-system cilium-pre-flight-check-8d4qw 0/1 Init:ErrImagePull 0 56s
kube-system cilium-pre-flight-check-p9945 0/1 Init:ErrImagePull 0 56s
$ kubectl describe ds cilium-pre-flight-check -n kube-system
Name: cilium-pre-flight-check
Pod Template:
Init Containers:
clean-cilium-state:
Image: k8s1:5000/cilium/cilium:latest
Dev builds of the latest cilium images are named "cilium-dev":
$ docker image ls
REPOSITORY TAG IMAGE ID CREATED SIZE
k8s1:5000/cilium/cilium-dev latest b8fc4648be0f 32 minutes ago 658MB
Fix this by using "cilium-dev" also for 'preflight.image' by default.
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
force-pushed
the
pr/jrajahalme/test-helm-wo-tiller
branch
from
0788071
to
67f78de
Compare
|
test-me-please |
aanm
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install Helm 3 instead of Helm 2. Use the "cilium-dev" image also for preflight as "cilium" image is not available for the local build.
Fixes: #10374
This change is