Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Fix typo in max options for bpf_lb #10386

Merged
merged 1 commit into from Feb 28, 2020
Merged

bpf: Fix typo in max options for bpf_lb #10386

merged 1 commit into from Feb 28, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Feb 28, 2020 •
edited by tgraf

ENABLE_HOST_SERVICES_UDP wasn't set when trying to max out the BPF program complexity.

This change is Reviewable

@pchaigno
bpf: Fix typo in max options for bpf_lb
fd6d1f5 
ENABLE_HOST_SERVICES_UDP wasn't set when trying to max out the BPF program
complexity.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Feb 28, 2020
@pchaigno pchaigno requested a review from a team as a code owner February 28, 2020 19:04
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 28, 2020
@pchaigno
Copy link
Member Author

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.1 Feb 28, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 45.555% when pulling fd6d1f5 on pr/pchaigno/fix-max-opt-bpf-lb into 0829785 on master.

@borkmann borkmann merged commit 302831a into master Feb 28, 2020
1.8.0 automation moved this from In progress to Merged Feb 28, 2020
@borkmann borkmann deleted the pr/pchaigno/fix-max-opt-bpf-lb branch February 28, 2020 21:07
@brb brb mentioned this pull request Mar 2, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.1 Mar 2, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.1 Mar 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.1 Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@borkmann borkmann borkmann approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.7.1
Backport done to v1.7
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @coveralls @brb @borkmann @joestringer