Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: Allow running several dev VMs concurrently #10400

Merged
merged 1 commit into from Mar 2, 2020
Merged

vagrant: Allow running several dev VMs concurrently #10400

merged 1 commit into from Mar 2, 2020

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 2, 2020 •
edited by tgraf

This pull request solves the conflict on the forwarded port of the dev VM to allow running several instances concurrently.

This change is Reviewable

@pchaigno
vagrant: Allow running several dev VMs concurrently
ac095a6 
This commit solves the conflict on the forwarded port of the dev VM to
allow running several instances concurrently.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added pending-review area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Mar 2, 2020
@pchaigno pchaigno requested a review from a team as a code owner March 2, 2020 06:52
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 2, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 45.561% when pulling ac095a6 on pr/pchaigno/fix-conflict-vagrant-vms into 39729f3 on master.

aanm
aanm approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd. I usually run 2 VMs at the same time and the ports are automatically derived by vagrant in case of a conflict.

@aanm aanm merged commit b68af48 into master Mar 2, 2020
1.8.0 automation moved this from In progress to Merged Mar 2, 2020
@aanm aanm deleted the pr/pchaigno/fix-conflict-vagrant-vms branch March 2, 2020 09:41
@pchaigno
Copy link
Member Author

pchaigno commented Mar 2, 2020

@aanm 2 test VMs? test/Vagrantfile has the correct option set.

@aanm
Copy link
Member

aanm commented Mar 2, 2020

@pchaigno no, 2 dev VMs

@aanm
Copy link
Member

aanm commented Mar 2, 2020

@pchaigno NFS=1 K8S=1 NWORKERS=1 ./contrib/vagrant/start.sh

@pchaigno
Copy link
Member Author

pchaigno commented Mar 2, 2020

@aanm You mean you run this command in 2 different clones and it works? 🤔

@aanm
Copy link
Member

aanm commented Mar 2, 2020

@pchaigno ah that I never tried. Only in the same clone

@pchaigno
Copy link
Member Author

pchaigno commented Mar 2, 2020

With NWORKERS=1, workers don't have forwarded ports, only the master does since we only need to connect kubectl to the master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchaigno @coveralls @aanm