Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf, xdp: migrate prefilter program to generic __ctx_buff #10404

Merged
merged 5 commits into from Mar 2, 2020

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Mar 2, 2020

Few more intermediate cleanups to get out of the pipe in meantime. Most notably to move the prefilter code over to generic __ctx_buff we can later build on top of.


This change is Reviewable

Move errno codes into its own include/bpf/errno.h header since it's
basic API for all type of programs we use.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added pending-review sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Mar 2, 2020
@borkmann borkmann requested review from brb and a team March 2, 2020 10:54
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

2 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 2, 2020
@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Mar 2, 2020
@borkmann
Copy link
Member Author

borkmann commented Mar 2, 2020

test-me-please

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bpf/include/bpf/verifier.h Outdated Show resolved Hide resolved
Move few more generic bits out of lib/common.h.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Get rid of xdp.h header since lib/ should not contain anything
context type specific. Move parts we can reuse into lib/common.h.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Remove boilerplate and switch data path to spdx license identifiers
similarly as has been done in the Linux kernel long ago.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
As the subject says, convert prefilter over to generic __ctx_buff.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann force-pushed the pr/xdp-prefilter-conversion branch from 7451d9e to a4574c3 Compare March 2, 2020 11:18
@borkmann
Copy link
Member Author

borkmann commented Mar 2, 2020

test-me-please

@coveralls
Copy link

coveralls commented Mar 2, 2020

Coverage Status

Coverage decreased (-0.05%) to 45.667% when pulling a4574c3 on pr/xdp-prefilter-conversion into b68af48 on master.

@borkmann borkmann merged commit e049cfa into master Mar 2, 2020
1.8.0 automation moved this from In progress to Merged Mar 2, 2020
@borkmann borkmann deleted the pr/xdp-prefilter-conversion branch March 2, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants