New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf, xdp: migrate prefilter program to generic __ctx_buff #10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move errno codes into its own include/bpf/errno.h header since it's basic API for all type of programs we use. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
added
pending-review
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
labels
Mar 2, 2020
Release note label not set, please set the appropriate release note. |
2 similar comments
Release note label not set, please set the appropriate release note. |
Release note label not set, please set the appropriate release note. |
borkmann
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Mar 2, 2020
test-me-please |
qmonnet
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Move few more generic bits out of lib/common.h. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Get rid of xdp.h header since lib/ should not contain anything context type specific. Move parts we can reuse into lib/common.h. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Remove boilerplate and switch data path to spdx license identifiers similarly as has been done in the Linux kernel long ago. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
As the subject says, convert prefilter over to generic __ctx_buff. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
force-pushed
the
pr/xdp-prefilter-conversion
branch
from
March 2, 2020 11:18
7451d9e
to
a4574c3
Compare
test-me-please |
vadorovsky
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/misc
This PR makes changes that have no direct user impact.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few more intermediate cleanups to get out of the pipe in meantime. Most notably to move the prefilter code over to generic __ctx_buff we can later build on top of.
This change is