Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datapath: Remove unnecessary matching on internal IP in proxy rules #10408

Merged
merged 1 commit into from Mar 4, 2020
Merged

datapath: Remove unnecessary matching on internal IP in proxy rules #10408

merged 1 commit into from Mar 4, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Mar 2, 2020 •
edited

Matching on the mark is sufficiently exact enough. Remove dependency on
understanding the internal IPv4 address.

This change is Reviewable

@tgraf tgraf added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 2, 2020
@tgraf tgraf requested a review from a team March 2, 2020 12:31
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 2, 2020
@tgraf tgraf requested a review from jrajahalme March 2, 2020 12:31
@tgraf
Copy link
Member Author

tgraf commented Mar 2, 2020

test-me-please

tklauser
tklauser reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the same be done for the IPv6 case as well (further down in the same function)?

@coveralls
Copy link

coveralls commented Mar 2, 2020 •
edited

Coverage Status

Coverage increased (+0.05%) to 45.689% when pulling 00035a7 on pr/tgraf/proxy-rule-no-hostip-dependency into fe98c5b on master.

@tgraf
Copy link
Member Author

tgraf commented Mar 3, 2020

Could the same be done for the IPv6 case as well (further down in the same function)?

Yes, good point. I'll make that change.

@tgraf
datapath: Remove unnecessary matching on internal IP
00035a7 
Matching on the mark is sufficiently exact enough. Remove dependency on
understanding the internal IPv4 address.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/proxy-rule-no-hostip-dependency branch from e03b96a to 00035a7 Compare March 3, 2020 14:20
@tgraf
Copy link
Member Author

tgraf commented Mar 3, 2020

test-me-please

@tgraf tgraf merged commit f8b6a14 into master Mar 4, 2020
1.8.0 automation moved this from In progress to Merged Mar 4, 2020
@tgraf tgraf deleted the pr/tgraf/proxy-rule-no-hostip-dependency branch March 4, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@aanm aanm aanm approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgraf @coveralls @tklauser @aanm