kubernetes: do not disable node routes for portmap #10415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since not all CNIs handle routing, e.g. portmap, we should still keep `enable-local-node-route` set to true in the portmap case as this CNI does not create any routes automatically. Signed-off-by: André Martins <andre@cilium.io>
aanm
added
pending-review
area/cni
|
Release note label not set, please set the appropriate release note. |
3 similar comments
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
Release note label not set, please set the appropriate release note. |
|
test-me-please |
aanm
added
the
release-note/bug
borkmann
approved these changes
Mar 3, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Needs backport from master
in 1.7.1
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.1
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since not all CNIs handle routing, e.g. portmap, we should still keep
enable-local-node-routeset to true in the portmap case as this CNIdoes not create any routes automatically.
Signed-off-by: André Martins andre@cilium.io
This change is