daemon: remove deprecated and hidden --sidecar-http-proxy option #10432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --sidecar-http-proxy has been hidden and deprecated since Cilium 1.2. Using it has no effect apart from a warning being logged. It's also hidden and doesn't appear in documentation anymore, so remove it. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
pending-review
release-note/misc
|
test-me-please |
|
I'm not sure whether there should be a note in the upgrade guide for this. Given the option is hidden already and it was deprecated in v1.2, it's probably not worth mentioning there. |
|
test-me-please |
aanm
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--sidecar-http-proxyhas been hidden and deprecated since Cilium1.2. Using it has no effect apart from a warning being logged. It's
also hidden and doesn't appear in documentation anymore, so remove it.
This change is