v1.6 backports 2020-03-04 #10443
Merged
v1.6 backports 2020-03-04 #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 37d11f6 ] We attempted to avoid locking the main cache while updating expired entries from endpoints. This left a small window where an entry is removed from the global cache outright but hasn't been re-populated by endpoints. This would only manifest when a DNS lookup existed in multiple endpoints but one had evicted the entry. The new code holds the global cache's lock while clearing and updating from all endpoint caches, avoiding the race. Signed-off-by: Ray Bejjani <ray@isovalent.com> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit 8a76414 ] The broken link was caused by using the 'latest' URL domain and path as root. \ |SCM_WEB|\/examples/kubernetes/1.10/cilium-pre-flight-with-rm-svc-v2.yaml Therefore the URL picked up the most recent tags, and post 1.5.12 the path `/examples/kubernetes/1.X` were removed, so all newly built URLs were broken. This change makes the URL static to the release path of `1.5.12`. If there are other options to keep the URL tagged within the `1.5.x` minor versions; I'm interested in learning about it, but this is a quick fix. Fixes: #10391 Signed-off-by: Joshua Roppo <joshroppo@gmail.com> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit f1a8fc1 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
kind/backports
|
never-tell-me-the-odds |
joestringer
approved these changes
Mar 4, 2020
|
I investigated the failure and am convinced it is not a regression but a flake as described in #10446: Ignoring failure to override merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not backported as these depend on other changes not backported to v1.6:
Once this PR is merged, you can update the PR labels via:
This change is