v1.5 backports 2020-03-04 #10445
Merged
v1.5 backports 2020-03-04 #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit d8443c5 ] If commit message is not a proper regular expression, check-stable script crashes (`bpf,option: Fix EPHE**R**MERAL typo` is an example). This change causes `git log` to not use commit message header as a regex, but rather use simple string comparison. Signed-off-by: Maciej Kwiek <maciej@isovalent.com> Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
…cilium [ upstream commit 4c40755 ] Recently Istio PODs have been lingering in terminating state long after deletion. It appears that kubelet on k8s2-1.17 is not happy that istio-system namespace has been deleted. Deletion of the namespace usually automatically deletes all the PODs in it. It may also be that the termination fails to complete since the Cilium DS is being deleted right after the istio-system namespace is deleted. k8s2 kubelet[3338]: W0225 ... 3338 status_manager.go:546] Failed to update status for pod "istio-citadel-7859cc956c-74474_istio-system(9a0a2875-076b-4670-a9b4-13f92f6c7240)": failed to patch status "... \"state\":{\"terminated\":{\"exitCode\":0,\"finishedAt\":null,\"startedAt\":null}}" for pod "istio-system"/"istio-citadel-7859cc956c-74474": namespaces "istio-system" not found Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
[ upstream commit f1a8fc1 ] Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme
added
pending-review
kind/backports
|
never-tell-me-the-odds |
joestringer
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not backported due to dependencies to non-backported commits:
Once this PR is merged, you can update the PR labels via:
This change is