Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Implements Documentation to install Cilium on k3s #10476

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Docs: Implements Documentation to install Cilium on k3s #10476

merged 1 commit into from
Mar 6, 2020

Conversation

seanmwinn
Copy link
Contributor

@seanmwinn seanmwinn commented Mar 5, 2020

Adds documentation to install Cilium on K3s (https://k3s.io) - a certified distribution of Kubernetes. Previously there was no documentation to create a working K3s sandbox environment running Cilium.

Fixes: #10471

Signed-off-by: Sean Winn sean@isovalent.com


This change is Reviewable

@seanmwinn seanmwinn requested a review from a team as a code owner March 5, 2020 00:31
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@coveralls
Copy link

coveralls commented Mar 5, 2020

Coverage Status

Coverage increased (+0.03%) to 45.636% when pulling f5a7901 on seanmwinn:k3s-install into 6abebd0 on cilium:master.

@joestringer joestringer added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Mar 5, 2020
@joestringer
Copy link
Member

test-docs-please

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice and easy :-)

(I didn't try it, but I read through)

@@ -273,6 +275,7 @@ frontend
fs
fwmark
gRPC
gc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see where this is used in the document, is this failing on master somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I ran the doc tests I was screamed at that this was failing so it was added, but not sure where it came from... so I just updated the commit in my source repo

Documentation/spelling_wordlist.txt Show resolved Hide resolved
@joestringer
Copy link
Member

test-docs-please

Fixes: #10471
needs-backport/1.7
Signed-off-by: Sean Winn <sean@isovalent.com>
@tgraf
Copy link
Member

tgraf commented Mar 6, 2020

test-docs-please

@tgraf tgraf merged commit f85d314 into cilium:master Mar 6, 2020
1.8.0 automation moved this from In progress to Merged Mar 6, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.2 Mar 6, 2020
@borkmann
Copy link
Member

borkmann commented Mar 6, 2020

@seanmwinn noticed that in your commit msg you had written needs-backport/1.7. We usually add it to the labels when PR is created.

@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.7.2
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

Docs: Document Cilium installation on k3s
6 participants