-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Improve deployment section #10479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Mar 5, 2020
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Mar 5, 2020
- Make Helm version reqs harder to miss - Clarify what happens if Helm 3 is to be used along with Helm 2 Fixes #10418 Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
We used to call it 'Prepare & Deploy' as there was a `helm template' step, now we simply run `helm install`. Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper
force-pushed
the
pr/errordeveloper/fix-10418
branch
from
March 5, 2020 11:01
8006d53
to
4178d07
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
The author needs to add signoff to their commits before merge.
label
Mar 5, 2020
test-docs-please |
aanm
reviewed
Mar 5, 2020
joestringer
approved these changes
Mar 5, 2020
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
test-docs-please |
@joestringer @aanm I think this would is ready to be merged :) |
aanm
approved these changes
Mar 9, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
Mar 16, 2020
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.2
Mar 16, 2020
maintainer-s-little-helper
bot
moved this from Backport pending to v1.7
to Backport done to v1.7
in 1.7.2
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10418
This change is