Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Improve deployment section #10479

Merged
merged 3 commits into from
Mar 9, 2020
Merged

doc: Improve deployment section #10479

merged 3 commits into from
Mar 9, 2020

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Mar 5, 2020

Fixes: #10418

doc: Make Helm version requirements harder to miss, add notes on Helm 2+3 compatibility

This change is Reviewable

@errordeveloper errordeveloper added the release-note/misc This PR makes changes that have no direct user impact. label Mar 5, 2020
@errordeveloper errordeveloper requested a review from a team as a code owner March 5, 2020 10:59
@maintainer-s-little-helper

This comment has been minimized.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 5, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 5, 2020
- Make Helm version reqs harder to miss
- Clarify what happens if Helm 3 is to be used along with Helm 2

Fixes #10418

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
We used to call it 'Prepare & Deploy' as there was a `helm template'
step, now we simply run `helm install`.

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 5, 2020
@tklauser
Copy link
Member

tklauser commented Mar 5, 2020

test-docs-please

@coveralls
Copy link

coveralls commented Mar 5, 2020

Coverage Status

Coverage increased (+0.01%) to 45.621% when pulling c89065d on pr/errordeveloper/fix-10418 into b3b29b3 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.2 Mar 5, 2020
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper
Copy link
Contributor Author

test-docs-please

@errordeveloper
Copy link
Contributor Author

@joestringer @aanm I think this would is ready to be merged :)

@aanm aanm merged commit 8ea7239 into master Mar 9, 2020
1.8.0 automation moved this from In progress to Merged Mar 9, 2020
@aanm aanm deleted the pr/errordeveloper/fix-10418 branch March 9, 2020 23:24
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.7 in 1.7.2 Mar 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.7 to Backport done to v1.7 in 1.7.2 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.7.2
Backport done to v1.7
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

Clarify Helm version requirements
7 participants