Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update hubble dependency to get rid of gojay #10484

Merged
merged 1 commit into from Mar 5, 2020
Merged

vendor: update hubble dependency to get rid of gojay #10484

merged 1 commit into from Mar 5, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Mar 5, 2020 •
edited by tgraf

Commit 3b21654 added a hidden observe subcommand. However, that pulled in gojay, a dependency that was subsequently removed from hubble (see cilium/hubble#170).

This commit updates hubble to get rid of the gojay dependency (and its dependencies).

This change is Reviewable

@rolinh
vendor: update hubble dependency to get rid of gojay
d4e4ce3 
Commit 3b21654 added a hidden `observe`
subcommand. However, that pulled in gojay, a dependency that was
subsequently removed from hubble
(see cilium/hubble#170).

This commit updates hubble to get rid of the gojay dependency (and its
dependencies).

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Mar 5, 2020
@rolinh rolinh requested review from a team as code owners March 5, 2020 14:10
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

2 similar comments
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Mar 5, 2020
@rolinh rolinh added the release-note/misc This PR makes changes that have no direct user impact. label Mar 5, 2020
@tklauser
Copy link
Member

tklauser commented Mar 5, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 45.66% when pulling d4e4ce3 on pr/rolinh/remove-gojay into 8ddc98e on master.

@joestringer joestringer merged commit 56aa241 into master Mar 5, 2020
1.8.0 automation moved this from In progress to Merged Mar 5, 2020
@joestringer joestringer deleted the pr/rolinh/remove-gojay branch March 5, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@michi-covalent michi-covalent Awaiting requested review from michi-covalent

Assignees
No one assigned
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rolinh @tklauser @coveralls @aanm @joestringer